[v3 PATCH] PR libstdc++/66338

Jonathan Wakely jwakely@redhat.com
Thu May 26 15:30:00 GMT 2016


On 26/05/16 01:07 +0300, Ville Voutilainen wrote:
>On 25 May 2016 at 16:55, Jonathan Wakely <jwakely@redhat.com> wrote:
>> On 24/05/16 19:49 +0300, Ville Voutilainen wrote:
>>>
>>> On 24 May 2016 at 19:35, Ville Voutilainen <ville.voutilainen@gmail.com>
>>> wrote:
>>>>
>>>> Slight tweak. The avoidance of _NotSameTuple wasn't quite correct for
>>>> the templates that
>>>> take const tuple<_UElements...>& or  tuple<_UElements...>&& instead of
>>>> const _UElements&...
>>>> or _UElements&&...
>>>>
>>>> This patch introduces a new helper alias to cover those cases and
>>>> takes it into use where appropriate.
>>>> All tests pass, but I don't have any sane tests to verify this tweak.
>>>
>>>
>>>
>>> ..and I don't need to be quite so round-about in the new helper, it
>>> can just check !is_same
>>> instead of doing a nested _TC call. Changelog the same as in the previous
>>> one.
>>
>>
>> OK for trunk - thanks.
>>
>
>Ack, I will do the mechanics in the forthcoming days, but here's a
>question: what do we want to do
>about this patch for the gcc6-branch? I fully appreciate being careful
>and not committing to the branch right now,
>but presumably this patch is a candidate for backporting to gcc6.

Yes, I think so.

There's a trade-off between giving it more time on the trunk for any
issues to arise before we backport it, or putting it on the branch now
and giving more time for problems to show up there because more people
are testing the branch.

I think it shouldn't cause any regressions, so can go on the branch
sooner rather than later.



More information about the Libstdc++ mailing list