[patch] libstdc++: fix ext/rope::dump() bug

Jonathan Wakely jwakely@redhat.com
Mon Jul 25 12:56:00 GMT 2016


On 25/07/16 20:26 +0800, Georeth Chow wrote:
>Hello, maintainers.
>
>Recently, I tried to figure out how the rope container works by
>dumping the content. I found that the implementation of rope::dump()
>has a misspell bug which use a static member function as a enum value.
>
>It seems that the original SGI STL implementation doesn't have this bug.
>
>bug trigger code below.
>
>#include <ext/rope>
>int main() {
>    __gnu_cxx::crope r(100, 'x');
>    r.dump();
>    return 0;
>}
>
>patch is attached.

Thanks for the patch, I've committed it to trunk.

    Fix missing qualification in <ext/rope>
    
    2016-07-25  Georeth Chow  <georeth2010@gmail.com>
    
        * include/ext/ropeimpl.h (rope<>::_S_dump(_RopeRep*, int)): Qualify
        _S_concat enumerator.
        * testsuite/ext/rope/6.cc: New test.





More information about the Libstdc++ mailing list