[v3 PATCH] Implement P0307R2, Making Optional Greater Equal Again.
Jonathan Wakely
jwakely@redhat.com
Tue Jul 12 22:31:00 GMT 2016
On 11/07/16 23:41 +0300, Ville Voutilainen wrote:
>@@ -785,41 +785,60 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
> }
> };
>
>+ template<typename _Tp>
>+ using __optional_relop_t =
>+ enable_if_t<is_constructible<bool, _Tp>::value, bool>;
Should this be is_convertible<_Tp, bool> instead?
> template<typename _Tp>
>- constexpr bool
>+ constexpr auto
> operator!=(const optional<_Tp>& __lhs, _Tp const& __rhs)
Dunno why this has _Tp const& rather than const _Tp&, could you fix it
while you're in the file anyway? It's a bit confusing to have one
place using a different style.
More information about the Libstdc++
mailing list