Improve insert/emplace robustness to self insertion

[Jonathan Wakely]

On 09/07/16 13:47 -0400, David Edelsohn wrote:
>This patch has caused some new libstdc++ testsuite failures on AIX.

Which patch?

My last patch only added a new test, that can't have caused failures
in unrelated tests.

https://gcc.gnu.org/ml/libstdc++-cvs/2016-q3/msg00021.html



>FAIL: 23_containers/list/debug/insert4_neg.cc (test for excess errors)
>
>Excess errors:
>
>/tmp/20160708/powerpc-ibm-aix7.1.0.0/libstdc++-v3/include/debug/formatter.h:387:7:
>error: __gnu_debug::_Error_formatter&
>__gnu_debug::_Error_formatter::_M_iterator(const _Iterator&, const
>char*) [with _Iterator = __gnu_debug::_Safe_iterator
><std::_List_const_iterator<int>, std::__debug::list<int> >] causes a
>section type conflict with __gnu_debug::_Error_formatter&
>__gnu_debug::_Error_formatter::_M_iterator(const _Iterator&, const
>char*) [with _Iterator =
>__gnu_debug::_Safe_iterator<std::_List_iterator<int>,
>std::__debug::list<int> >]
>
>FAIL: 23_containers/deque/debug/insert4_neg.cc (test for excess errors)
>
>Excess errors:
>
>/tmp/20160708/powerpc-ibm-aix7.1.0.0/libstdc++-v3/include/debug/formatter.h:387:7:
>error: __gnu_debug::_Error_formatter&
>__gnu_debug::_Error_formatter::_M_iterator(const _Iterator&, const
>char*) [with _Iterator = __gnu_debug::_Safe_iterator
><std::_Deque_iterator<int, int&, int*>, std::__debug::deque<int> >]
>causes a section type conflict with __gnu_debug::_Error_formatter&
>__gnu_debug::_Error_formatter::_M_iterator(const _Iterator&, const
>char*) [with _Iterator =
>__gnu_debug::_Safe_iterator<std::_Deque_iterator<int, const int&,
>const int*>, std::__debug::deque<int> >]
>
>Thanks, David