[patch] std::experimental::ostream_joiner

Jonathan Wakely jwakely@redhat.com
Sat May 2 18:04:00 GMT 2015


On 02/05/15 19:34 +0200, Daniel Krügler wrote:
>2015-05-02 19:14 GMT+02:00 Jonathan Wakely <jwakely@redhat.com>:
>> The last piece of the Library Fundamentals 2 TS (until next week when
>> all of v1 gets voted into v2, when it will include the v1 stuff we're
>> missing).
>>
>> Tested powerpc64le-linux, committed to trunk.
>
>Do you really want to copy the ugliness of the Standard specification
>for in-class members or could this be made more readable as follows
>(affects four members):
>
>ostream_joiner<_DelimT, _CharT, _Traits>&
>=>
>ostream_joiner&
>
>? [I'm asking because I have not seen this to be the general style
>used in libstdc++]

Good point, I should probably stop working now, I've already spent my
whole Saturday and I'm clearly not paying attention properly!

The TS should be fixed to use the injected-class-name too:
https://github.com/cplusplus/fundamentals-ts/pull/56

Fixed by this patch, tested powerpc64le-linux and committed to trunk.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.txt
Type: text/x-patch
Size: 1830 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/libstdc++/attachments/20150502/ee316b94/attachment.bin>


More information about the Libstdc++ mailing list