[PATCH][libstdc++][Testsuite] isctype test fails for newlib.

Jonathan Wakely jwakely@redhat.com
Mon Mar 9 12:47:00 GMT 2015


On 13/02/15 13:48 +0000, Matthew Wahab wrote:
>On 11/02/15 15:43, Jonathan Wakely wrote:
>>On 11/02/15 11:14 +0000, Matthew Wahab wrote:
>>>Attached the fixed patch.
>>>Tested by running check-target-libstdc++-v3, with the modified tests,
>>>for arm-none-eabi and aarch64-none-linux-gnu.
>>>
>>>Ok to commit?
>>
>>OK, thanks.
>
>Some DOS line endings were introduced into the char/isctype.cc file 
>when I committed this change These aren't visible in a terminal or 
>with svn diff but do show up in emacs. This is causing the test to 
>fail in local runs. The wchar_t/isctype.cc file isn't affected.
>
>I've committed the attached patch as obvious, it just removes the DOS 
>line endings from the file.

That patch still left DOS line-endings in the file.

The test also now fails for newlib targets not using
--enable-clocale=newlib so I'm just going to disable the check for
'\n' entirely, since it doesn't have consistent behaviour on newlib.

Tested x86_64-linux, committed to trunk. Hopefully we can finally
close this one for good!


-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.txt
Type: text/x-patch
Size: 1662 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/libstdc++/attachments/20150309/1cae5beb/attachment.bin>


More information about the Libstdc++ mailing list