[PATCH][libstdc++][Testsuite] isctype test fails for newlib.

Matthew Wahab matthew.wahab@arm.com
Wed Feb 11 11:14:00 GMT 2015


On 10/02/15 08:51, Matthew Wahab wrote:
> On 09/02/15 23:17, Hans-Peter Nilsson wrote:
>> On Mon, 9 Feb 2015, Matthew Wahab wrote:
>>> Attached a patch to replace the test for macro __NEWLIB__ with a test for
>>> macro NEWLINE_IN_CLASS_BLANK, defined by
>>>    { dg-additional-options "-DNEWLINE_IN_CLASS_BLANK" { target newlib } }
>>>
>>> Tested with check-target-libstdc++-v3, with the modified tests, for
>>> arm-none-eabi and aarch64-none-linux-gnu.
>>>
>>> Does this look ok to commit?
>>
>> Not valid for approval, but that's what I meant!
>> Modulo the typo forgetting to
>> s/__NEWLIB__/NEWLINE_IN_CLASS_BLANK/ in the ifdef in
>> wchar_t/isctype.cc of course.

Attached the fixed patch.
Tested by running check-target-libstdc++-v3, with the modified tests, 
for arm-none-eabi and aarch64-none-linux-gnu.

Ok to commit?
Matthew

libstdc++-v3/
2015-02-11  Matthew Wahab  <matthew.wahab@arm.com>

	* testsuite/28_regex/traits/char/isctype.cc (test01): Replace test
	for __NEWLIB__ macro with a dejagnu set macro.
	* testsuite/28_regex/traits/wchar_t/isctype.cc (test01): Likewise.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: isctype_target.patch
Type: text/x-patch
Size: 2015 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/libstdc++/attachments/20150211/e8ff5819/attachment.bin>


More information about the Libstdc++ mailing list