[patch ping] libstdc++ testsuite cxxflags

Jonathan Wakely jwakely@redhat.com
Fri May 30 11:11:00 GMT 2014


On 30/05/14 08:53 +0100, Ramana Radhakrishnan wrote:
>With all the other build breakages in the past week,  I've just
>started seeing the first set of testresults from an auto-tester. It
>looks like on a cross test using rhe5 / x86_64  with the version of
>tcl8.4 I'm using I see the same errors that David saw.
>
>The testsuite starts running if I tried the above
>
>regexp ".*-O" $cxxflags
>
>Is this going to be applied - what gives ?

Fixed with the attached patch.

Tested x86_64-linux (but onnly with Tcl 8.5), committed to trunk.


-------------- next part --------------
commit 8e72d35ed67a51df88c359249590e266c476044e
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Fri May 30 11:10:57 2014 +0100

    	* testsuite/lib/libstdc++.exp (libstdc++_init): Adjust regexp to
    	work with previous versions of Tcl.

diff --git a/libstdc++-v3/testsuite/lib/libstdc++.exp b/libstdc++-v3/testsuite/lib/libstdc++.exp
index 2b2a38b..d91bed6 100644
--- a/libstdc++-v3/testsuite/lib/libstdc++.exp
+++ b/libstdc++-v3/testsuite/lib/libstdc++.exp
@@ -283,7 +283,7 @@ proc libstdc++_init { testfile } {
     append cxxflags " "
     append cxxflags [getenv CXXFLAGS]
 
-    if ![regexp "\-O" $cxxflags] {
+    if ![regexp ".*-O" $cxxflags] {
 	append cxxflags " -g -O2"
     }
 


More information about the Libstdc++ mailing list