Porting pretty printers to Python 2+3

[Jonathan Wakely]

On 21/05/14 15:45 -0400, Samuel Bronson wrote:
>I have two patches:

N.B. all GCC patches need to be sent to gcc-patches@gcc.gnu.org,
libstdc++ ones get sent to this list and that one.


>[PATCH 1/2] Make libstdc++ testsuite work with pre-color GCC versions
>
>This is just to make it easy to test my changes, since my computer is
>evidently too pathetic to build GCC.

Testing an installed compiler would usually be done to test the same
version as the testsuite belongs to, but I suppose this change doesn't
hurt.

>[PATCH 2/2] Port libstdc++ pretty-printers & assiocated tests to Python2+3
>
>My goal here is to do what Mathias Klose originally tried to do with
><http://patchwork.ozlabs.org/patch/287368/>; my patch is somewhat
>loosely based on his.
>
>(I guess I'm going to need to work in a reference to
><https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58962> ...)
>
>My changes give me the exact same set of failures in GDB 7.7 when
>linked with python2.7 and with python3.3, for what seem to be the
>exact same reasons; I'm expecting them to go away in GDB 7.7.1 once I
>get that built.

Which failures? There shouldn't be any, although consistency is a good
start!

>Besides review, I believe I also need an Assignment Form -- I'm
>assuming I can't get away with claiming that this code is effectively
>part of GDB, and that my GDB assignment papers are thus all I need?

I don't think you can get away with that, no, sorry.
The first patch is probably trivial enough to take without an
assignment though.

>To actually run the tests, I configured just the libstdc++-v3 subtree
>and then ran:
>
>$ make check RUNTESTFLAGS='--debug --directory libstdc++-prettyprinters'

I'm not sure what the --debug flag does but I just run:

  make check RUNTESTFLAGS=prettyprinters.exp