[patch 3/N] std::regex refactoring - _Executor DFS / BFS

Tim Shen timshen91@gmail.com
Mon Apr 28 19:24:00 GMT 2014


On Mon, Apr 28, 2014 at 3:10 PM, Jonathan Wakely <jwakely@redhat.com> wrote:
> Data members are accessed through the 'this' pointer, which can
> require an indirection and be harder to optimise than a function
> parameter.

It doesn't matter if this variable is not frequently checked. But
let's just use the function parameter and expecting compiler's
optimization.

> My concern is that making it a template parameter causes twice as much
> code to be instantiated, which makes executables bigger and can cause
> more I-cache misses.

Worth a try. Will you make the change or will I? It seems to be
simpler doing than talking.


-- 
Regards,
Tim Shen



More information about the Libstdc++ mailing list