[Patch 1/3] Use manual regex algorithm switching
Jonathan Wakely
jwakely@redhat.com
Fri Apr 25 23:56:00 GMT 2014
On 25/04/14 18:14 -0400, Tim Shen wrote:
>On Fri, Apr 25, 2014 at 5:14 PM, Jonathan Wakely <jwakely@redhat.com> wrote:
>> I wonder if this would be simpler to read like this:
>>
>> if (!__re._M_automaton->_M_has_backref
>> #ifndef _GLIBCXX_REGEX_USE_THOMPSON_NFA
>> && __policy == _RegexExecutorPolicy::_S_alternate
>> #endif
>> )
>
>I don't think this has equivalent logic. If
>_GLIBCXX_REGEX_USE_THOMPSON_NFA is not defined, the _S_alternate
>should also work, for testing purpose.
That's why I thought #ifndef would work, not #ifdef
>Other parts is good. Sorry for those inconvenience :(
No problem, that's why we all review each other's code publicly :)
More information about the Libstdc++
mailing list