Remove algo logic duplication Round 3
Paolo Carlini
paolo.carlini@oracle.com
Mon Sep 23 20:30:00 GMT 2013
On 9/23/13 3:07 PM, François Dumont wrote:
> Hi
>
> Here is a new version of the patch. Marc idea to use template
> operators indeed simplified the code, it avoids some binding
> operations. I also review the name of helper functions so there are
> much fewer of them and so that you only need to know what kind of
> operation you need to know what function you must use, much cleaner I
> think.
>
> I also get rid of the attempt to move as much code as possible
> into __detail namespace to limit the patch. Moving code to __detail
> namespace might be part of a future patch if it is considered of
> interest or necessary for any other purpose.
>
> I have also added a number of test case using std::vector<bool>
> but as said Marc, even if big, this is a safe patch cause not
> detectable from a user code point of view.
Ok, you almost convinced me. Let's make sure Marc and the other
interested people have a further look at this for a few days and then
let's go ahead. I have one minor doubt: if I'm not misreading the diff,
I'm seeing _GLIBCXX_STD_A uses going away completely (is_permutation?)
and that seems suspect: can you please review those and make sure
everything is fine? In particular you should test check-parallel. That
code isn't really up to the C++11 requirements, but not regressing
should be very easy.
Paolo.
More information about the Libstdc++
mailing list