[patch] Make vector::at() assertion message more useful (try #2)

Paolo Carlini paolo.carlini@oracle.com
Mon Sep 23 16:24:00 GMT 2013


Hi,

On 9/23/13 11:02 AM, Paul Pluzhnikov wrote:
> On 9/23/13 7:54 AM, Paolo Carlini wrote:
>
>>> Testing this patch:
>> In fact, however, that unsigned long long instantiation isn't
>> *unconditionally* available, see locale-inst.cc.
>
> Thanks,
>
>> I think we have to use
>> unsigned long as a fall back controlled by the same macro. And please
>> add a comment explaining those contortions having to do with the
>> available instantiations. Patch pre-approved.
>
> Does this look right?
Yes. Nit, in the comment I would also explicitly mention locale-inst.cc.

Thanks!
Paolo.



More information about the Libstdc++ mailing list