[PATCH] fix PR target/54407

Jack Howarth howarth@bromo.med.uc.edu
Mon Mar 11 14:57:00 GMT 2013


On Tue, Oct 16, 2012 at 12:26:39PM -0700, Mike Stump wrote:
> On Oct 16, 2012, at 10:28 AM, Dominique Dhumieres <dominiq@lps.ens.fr> wrote:
> >> I'm not a big fan of just hiding the bug; why not just xfail it of darwin10 and darwin[5-9]?
> > 
> > I am viewing xfail for bugs that have a chance to be fixed some day.
> > Since the bug is fixed for darwin11 and 12, I doubt that Apple will backport it.
> > I would prefer a dg-skip-if may be with a comment about the bug.
> 
> Not a huge fan of skip either, but, if you guys really want to, that's ok by me.  Please do include a comment and a pointer to the Apple bug report number if available else a pointer to the gcc PR number where we talk about why we are skipping it.  Something like: OS bug, see gcc PR/x.  Short, easy to understand and one can read the PR for details, if one is really, really bored.

Mike,
   As I mentioned back in Oct, there is no explicit radar for this bug. It just happened to be fixed in the
rewrites of the pthread suppport for darwin11 and later. Dominique would like to see this committed for
gcc 4.8. Can you do the commit? I have attached the patch with updated ChangeLog.
         Jack
-------------- next part --------------
  The attached patch eliminates the execution failures in 30_threads/condition_variable/54185.cc
on darwin by limiting the test to darwin11 or later. The test is disabled on darwin10 and earlier
which has broken pthread support. Tested on x86_64-apple-darwin10 and x86_64-apple-darwin12. 
Okay for gcc trunk?

libstdc++-v3/testsuite/

2013-03-11  Dominique Dhumieres  <dominiq@lps.ens.fr>
	    Jack Howarth <howarth@bromo.med.uc.edu>

	PR target/54407
	* 30_threads/condition_variable/54185.cc: Skip for darwin < 11.

Index: libstdc++-v3/testsuite/30_threads/condition_variable/54185.cc
===================================================================
--- libstdc++-v3/testsuite/30_threads/condition_variable/54185.cc	(revision 192494)
+++ libstdc++-v3/testsuite/30_threads/condition_variable/54185.cc	(working copy)
@@ -1,4 +1,4 @@
-// { dg-do run { target *-*-freebsd* *-*-netbsd* *-*-linux* *-*-solaris* *-*-cygwin *-*-darwin* powerpc-ibm-aix* } }
+// { dg-do run { target *-*-freebsd* *-*-netbsd* *-*-linux* *-*-solaris* *-*-cygwin *-*-darwin1[1-9]* powerpc-ibm-aix* } }
 // { dg-options " -std=gnu++0x -pthread" { target *-*-freebsd* *-*-netbsd* *-*-linux* powerpc-ibm-aix* } }
 // { dg-options " -std=gnu++0x -pthreads" { target *-*-solaris* } }
 // { dg-options " -std=gnu++0x " { target *-*-cygwin *-*-darwin* } }


More information about the Libstdc++ mailing list