[Patch] Refractor Thompson matcher
Tim Shen
timshen91@gmail.com
Tue Jul 30 23:11:00 GMT 2013
On Wed, Jul 31, 2013 at 7:03 AM, Paolo Carlini <paolo.carlini@oracle.com> wrote:
> Did you actually bootstrap & test the patch? Because you didn't last time,
> right?
I compiled it and run the 28_regex testsuite, nothing wrong happened
because there're all single-file testcases in it;
but I ignored the duplicated definition problem. It'll never happen in
the future. Sorry again.
> Please add FIXME comments to all the non-template functions in *.tcc files
> (which will be moved to *.cc files). To repeat: the inlines in *.tcc files
> must be all and only non-templates, as a temporary hack.
Added.
--
Tim Shen
More information about the Libstdc++
mailing list