[Patch] Refractor Thompson matcher

Paolo Carlini paolo.carlini@oracle.com
Mon Jul 29 08:26:00 GMT 2013


Hi,

On 07/29/2013 02:06 AM, Tim Shen wrote:
> On Mon, Jul 29, 2013 at 1:08 AM, Paolo Carlini <paolo.carlini@oracle.com> wrote:
>> Oh well, thanks. But then I expect specific testcases to come with it, for
>> the various values of the parameter, both the default and the other other
>> values. Otherwise, the idea isn't really immediately useful. See what I
>> mean?
> So I modified testcases to test both of them.
>
>> Also, please make sure that this change is in any case a step in the right
>> direction. I mean: I suppose that if we do this only the logic to control
>> automatically the switch is missing and when we add it we are done. Let's
>> not do it if I'm mistaken.
> Never mind, this patch makes them switch to be automatic(based on
> whether there're back-references in the regex), thanks to the
> full-featured regex scanner.
> A testcase is given too.
Ah, excellent. As usual, let's wait a day or so for further comments and 
then please commit the whole thing.

Minor nit: it's not clear to me why in the previous patch you added the 
includes of <map> and <queue>.

Thanks,
Paolo.



More information about the Libstdc++ mailing list