[Patch] Reimplment regex matcher using DFS

Tim Shen timshen91@gmail.com
Tue Jul 23 14:13:00 GMT 2013


On Tue, Jul 23, 2013 at 9:42 PM, Paolo Carlini <paolo.carlini@oracle.com> wrote:
> This doesn't make much sense to me: if the functions are inside a *.tcc file
> why are marked inline? First blush seem indeed good candidates for inline,
> but then should be in the *.h

My view is like this :
When I put something into the class definition, I expected it doesn't
frequently changing. It's part of the interfaces.
When I find some small function body, I inline it.

In the future the function _M_dfs_match() and
_M_dfs_search_from_first() may change. So I decide to pull them out of
the class definition.

Is this naive or not?


-- 
Tim Shen



More information about the Libstdc++ mailing list