Recent libstdc++ build failure in hashtable_policy.h on alpha, r201522

[François Dumont]

On 08/06/2013 11:40 PM, Paolo Carlini wrote:
>
> Hi,
>
>> I will try to do a full rebuild to see if I can reproduce cause the
>> classic incremental build worked for me.
> To be honest I'm not sure to understand what a classic incremental build is, but for sure a bootstrap failed on x86_64-linux too and earlier today I reverted the patch to ensure the other developers can keep on working. Thus, take your time, when you figure out the problem and the updated version is known to work fine we'll go ahead.
>
> Thanks,
> Paolo
>
Here is the patch again with the missing include in hashtable_c++0x.cc.

Ok to commit ?

2013-08-07  François Dumont  <fdumont@gcc.gnu.org>

     * include/bits/hashtable_policy.h (_Hashtable_alloc): New.
     (_ReuseOrAllocNode, _AllocNode): Adapt to use latter rather than
     _Hashtable.
     (_Before_begin<>): Remove.
     * include/bits/hashtable.h (_Hashtable): Inherit from
     _Hashtable_alloc and adapt. Restore _M_before_begin field.
     * src/c++11/hashtable_c++0x.cc: Add ext/alloc_traits.h include.
     * python/libstdcxx/v6/printers.py (StdHashtableIterator): Adapt
     access to hashtable before begin.
     * testsuite/23_containers/unordered_set/
     not_default_constructible_hash_neg.cc: Adapt dg-error line number.
     * testsuite/23_containers/unordered_set/instantiation_neg.cc:
     Likewise.


What I don't understand is why when I modify hashtable_policy.h 
hashtable_c++0x.cc is not automatically rebuilt when I call make into 
<build-folder>/x86_64-unknown-linux-gnu/libstdc++-v3. I need to touch 
hashtable_c++0x.cc itself to have it rebuilt, wouldn't it be possible to 
manage at least direct dependencies ?

This time I did a make clean to force a full rebuild.

François

-------------- next part --------------
A non-text attachment was scrubbed...
Name: hashtable.patch
Type: text/x-patch
Size: 44915 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/libstdc++/attachments/20130807/5c4b1db2/attachment.bin>