[PING^2] [C++ PATCH] Add overflow checking to __cxa_vec_new[23]

Florian Weimer fweimer@redhat.com
Tue Oct 30 16:31:00 GMT 2012


On 10/30/2012 05:17 PM, Paolo Carlini wrote:

> Sorry, I don't know the code well enough to review your patch, but since I'm in CC, I still don't understand why, instead of adding a full libstdc++ testcase you are extending a C++ testcase, in old-deja even, normally considered legacy.

AFAIK, this is the only place we have such a test.  I suppose I could it 
put it into testsuite/18_support, but I would have to duplicate a bit of 
the machinery of the original test case because I can't just write a 
class and take the address of its constructor and destructor (whose 
addresses are passed to the tested functions).  I really didn't want to 
do that because there are some platform dependencies (the __ARM_EABI__ 
#ifdef).

Not sure if this makes sense, but those were my reasons.

-- 
Florian Weimer / Red Hat Product Security Team



More information about the Libstdc++ mailing list