abs(long long)

Marc Glisse marc.glisse@inria.fr
Wed Oct 3 20:00:00 GMT 2012


On Wed, 3 Oct 2012, Gabriel Dos Reis wrote:

> On Tue, Oct 2, 2012 at 1:53 PM, Marc Glisse <marc.glisse@inria.fr> wrote:
>
>>         * include/c_std/cstdlib (abs(long long)): Define with
>>         __builtin_llabs when we have long long.
>>
>>         (abs(__int128)): Define when we have __int128.
>
> This change is OK

Thanks, I'll commit that part only.

>>         (div(long long, long long)): Use lldiv.
>
> not this one.

Ok. Note that glibc's implementation does more than just / and %. Possible 
reasons are:
1) glibc does useless work
2) libstdc++ has a bug
3) there are platforms supported by glibc but not by libstdc++

I choose to believe it is option 3.

-- 
Marc Glisse



More information about the Libstdc++ mailing list