hashtable local iterator

[François Dumont]

On 01/02/2012 02:27 PM, Paolo Carlini wrote:
> Hi,
>> Hi
>>
>>     Here is a proposition of patch compiling all your remarks.
>>
>> 2012-01-02  François Dumont <fdumont@gcc.gnu.org>
>>
>>         * include/bits/hashtable_policy.h (_Ebo_helper<>): Rename 
>> into the
>>         more specific _Hashtable_ebo_helper. Hide this implementation 
>> detail
>>         thanks to private inheritance.
>>
>>     Tested under x86_64 linux normal and debug mode.
>>
>> Ok to commit ?
> Can you please also adjust those comments referring to the deprecated 
> unary_function? Otherwise the patch looks good to me.
Like this Paolo ?

2012-01-02  François Dumont <fdumont@gcc.gnu.org>

         * include/bits/hashtable_policy.h (_Ebo_helper<>): Rename into the
         more specific _Hashtable_ebo_helper. Hide this implementation 
detail
         thanks to private inheritance.
         * include/bits/hashtable.h: Remove deprecated unary and binary
         function concepts from comments.

I also forget to react to the Solaris issue. I just wanted to tell that 
I don't see how I could have been more careful regarding the patch. Even 
if I now know that _N is reserved under Solaris there are surely many 
different reserved keywords under the numerous supported platforms. Is 
there a list of those keywords ? If so I can only imagine an automated 
test based on it to avoid this kind of regression even if writing this 
test will require more than a simple grep.

François

-------------- next part --------------
A non-text attachment was scrubbed...
Name: hashtable.patch
Type: text/x-patch
Size: 8799 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/libstdc++/attachments/20120102/447d19d5/attachment.bin>