debug abi breaking change patch
François Dumont
frs.dumont@gmail.com
Thu Feb 9 21:37:00 GMT 2012
Ok, I will fix the ChangeLog.
I know I can normally commit in the branch without approval but I am a
little bit like Morgan Freeman in The Shawshank Redemption, I can't go
anymore without asking ;-). No, I just want to share with you what I put
in this branch so that there are less questions when it will be time to
reintegrate it.
About keeping _M_get_mutex, I can implement it inline or do you think
that I should keep in the debug.cc ? I guess gcc should be able to
inline it where ever it relies, no ?
And yes, Paolo already told me that he and you will surely push some
stuff in this branch. Don't hesitate !
For info, on my side I had also plan to remove the _M_version
information in the safe iterators and sequences that do not use it, the
sequences where _M_invalidate_all has been overloaded in such a way that
it is not simply changing the sequence version. But after spending quite
some time trying to do so I realized that the _M_version information on
the safe iterator is also use to make it singular without touching to
its _M_sequence information which is used sometimes. So I finally won't
touch to anything regarding this version information.
François
On 02/08/2012 10:44 PM, Jonathan Wakely wrote:
>> * include/debug/safe_base.h (_Safe_iterator_base::_M_get_mutex):
>> Remove. (_Safe_sequence_base::_M_get_mutex): Remove and replace
>> with _M_mutex.
> The changelog format is wrong, the function names in parentheses
> should be on a new line.
>
> But otherwise, I think (someone please correct me if I'm wrong) you
> can commit to your own branches without approval. This change looks
> good to me anyway.
>
More information about the Libstdc++
mailing list