using xlocale to implement std::locale class

[François Dumont]

On 05/06/2011 09:25 PM, Sam Varshavchik wrote:
> Paolo Carlini writes:
>
>> On 05/05/2011 10:52 PM, Paolo Carlini wrote:
>>> Indeed, it would be nice if Sam could test the patch. I can also 
>>> look into it tomorrow or over the next days anyway.
>>>
>>> Francois, what did you mean exactly in the audit trail by: "For info 
>>> a regression has been reported using this patch so it is surely not 
>>> yet ready."? On which test? In which conditions?
>> In the meanwhile I re-diffed the patch vs current mainline and 
>> attached it to the PR.
>>
>> On GNU-Linux I'm seeing this fail:
>>
>> named_equivalence.exe: 
>> .../libstdc++-v3/testsuite/22_locale/messages_byname/named_equivalence.cc:67: 
>> void test01(): Assertion `s03 == "bitte"' failed.
>> FAIL: 22_locale/messages_byname/named_equivalence.cc execution test
>>
>> no idea at moment whether it's something serious or a small tweak on 
>> top of it would be enough. Maybe Sam can help...
>
> I don't think I'm running the testsuite correctly. I've executing make 
> check RUNTESTFLAGS='conformance.exp=messages*'. I do not get this 
> failure even though I have Francois' patch applied, and my out of tree 
> test for the original bug, that I'm linking directly against the built 
> libstdc++.a passes the test for the fix. Yet, make check seems to work 
> without applying the fix to messages_byname/named_equivalence.cc. But 
> if I stick VERIFY(0 == 1) in there, it fails.
>
> In any case, I think the existing regression tests should be trivially 
> modifiable to test Francois' patch too. All you need is to another 
> call to open() for another domain ("gcc" should be good enough), after 
> one of the existing calls. Without the messages patch, this should 
> make the regression test break. With the patch, it will still work.
>
>
Thanks Sam for the tips to work on my message facet issue, I will try 
with strace.

Here is attached the test I had written to challenge my patch using 
okular and pulseaudio catalogs. It should go into 
testsuite/22_locale/messages/members/char.

Regards

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 4.cc
Type: text/x-c
Size: 2156 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/libstdc++/attachments/20110506/5c3d1e50/attachment.bin>