[build] Move unwinder to toplevel libgcc (v2)

Rainer Orth ro@CeBiTec.Uni-Bielefeld.DE
Wed Aug 10 13:57:00 GMT 2011


"Joseph S. Myers" <joseph@codesourcery.com> writes:

>> This is strange: they copy explicitly goes into $(gcc_objdir): from
>> libgcc/Makefile.in:
>> 
>> install-unwind_h:
>>         cp unwind.h $(gcc_objdir)/include/unwind.h
>>         chmod a+r $(gcc_objdir)/include/unwind.h
>> 
>> For an in-tree build, the source directory cannot be read-only, for a
>> VPATH build I don't see how this can happen.  Could you please check?
>
> This is a VPATH build and the issue is that the *file* unwind.h is 
> readonly having been copied from a readonly source (and install-unwind_h 

I see.  I'd been thinking of a source tree mounted read-only, not the
actual files changed to be read-only.

> must, I suppose, end up getting called more than once so that the second 
> copy tries to copy over a readonly file; the 26478 fix was to remove the 

True: it is called once per multilib.

> target of the copy with rm -f before copying).

Makes sense.  Toplevel dependencies should take care that the file isn't
used by another target library in the small time window between removal
and copy.

Could you try the obvious patch?  It's probably quicker than me
recreating the setup.

Thanks.
	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University



More information about the Libstdc++ mailing list