[PATCH][libstdc++-v3 parallel mode] Correct part lengths calculation for parallel partial_sum
Johannes Singler
singler@kit.edu
Tue Jun 8 09:27:00 GMT 2010
Jonathan Wakely wrote:
> On 8 June 2010 09:05, Johannes Singler wrote:
>> Jonathan Wakely wrote:
>>> On 8 June 2010 08:21, Johannes Singler wrote:
>>>> This patch corrects the calculation of the part lengths for parallel
>>>> partial_sum, leading to the expected behavior for
>>>> partial_sum_dilation!=1, and thus better performance.
>>>>
>>>> Tested x86_64-unknown-linux-gnu: No regressions.
>>>>
>>>> Please approve for mainline.
>>>>
>>>> 2010-06-08 Johannes Singler <singler@kit.edu>
>>>>
>>>> * include/parallel/partial_sum.h
>>>> (__parallel_partial_sum_linear):
>>>> Correctly calculate part lengths for partial_sum_dilation!=1.
>>> Please declare each variable on its own line, as per
>>> http://gcc.gnu.org/onlinedocs/libstdc++/manual/source_code_style.html
>>>
>>> char* c = "abc"; // each variable goes on its own line, always.
>> Okay, I hope you like the attached version better.
>
> Yes, thanks. Are the casts to float necessary in the initializer for
> first_part_length? The 1.0 means the result will be a double anyway.
> Should that be 1.0f, or are the (float) casts just visual noise?
Good point, I have cleaned that up, and commited.
Johannes
More information about the Libstdc++
mailing list