Fwd: OpenMP vs. <math.h>

[Jeff Johnston]

Any thoughts on this?  The proposed patch has been applied to newlib's 
math.h.

-- Jeff J.

-------- Original Message --------
Subject: OpenMP vs. <math.h>
Date: Fri, 08 Jan 2010 12:42:35 -0600
From: Yaakov (Cygwin/X) <yselkowitz@users.sourceforge.net>
To: newlib@sources.redhat.com

POSIX allows for <math.h> functions to also be defined as macros.
Currently, only log2 and log2f are so defined.

These macros pose problems with a few projects which define their own
static/inline/template log2() (off the top of my head, I can think of 2:
the CRAN rgl module, and OpenCV; both are C++).  Of course, those can be
fixed with an #undef log2 after the #include's.

However, I just encountered tonight a much larger conflict: OpenMP/C++
and <math.h> are incompatible.  STC attached:

$ g++ -D_GLIBCXX_PARALLEL -fopenmp openmp.cxx -lgomp
In file included from
/usr/lib/gcc/i686-pc-cygwin/4.3.4/include/c++/parallel/algobase.h:46,
                    from
/usr/lib/gcc/i686-pc-cygwin/4.3.4/include/c++/bits/stl_algobase.h:1137,
                    from
/usr/lib/gcc/i686-pc-cygwin/4.3.4/include/c++/bits/char_traits.h:46,
                    from
/usr/lib/gcc/i686-pc-cygwin/4.3.4/include/c++/ios:46,
                    from
/usr/lib/gcc/i686-pc-cygwin/4.3.4/include/c++/ostream:45,
                    from
/usr/lib/gcc/i686-pc-cygwin/4.3.4/include/c++/iostream:45,
                    from openmp.cxx:7:
/usr/lib/gcc/i686-pc-cygwin/4.3.4/include/c++/parallel/base.h:112:
error: expected `)' before ‘/’ token

It gets even worse if you #include <algorithm> as well, and no, it
doesn't help to #include <cmath>, although moving the math include after
all other includes does work.

As this would seem to affect all Newlib platforms, I think the most
plausible solution is to make the log2 macros dependent on !__cplusplus.
   Patch attached.


Yaakov
Cygwin/X


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: openmp.cxx
URL: <http://gcc.gnu.org/pipermail/libstdc++/attachments/20100111/950075f9/attachment.cxx>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: newlib-log2-cxx.patch
Type: text/x-patch
Size: 1074 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/libstdc++/attachments/20100111/950075f9/attachment.bin>