[PATCH][libstdc++-v3 parallel mode] Tackle XXX todos: move compare to last place

Johannes Singler singler@ira.uka.de
Wed Sep 23 14:53:00 GMT 2009


This patch fixes a small todo, and removes another (cannot remove
duplicates of std:: functors because they have different structure).

Tested x86_64-unknown-linux-gnu: No regressions

Please approve for mainline.

2009-09-23  Johannes Singler  <singler@ira.uka.de>

        * include/parallel/algobase.h
        (__lexicographical_compare_switch): Move compare template
        parameter to the end as of others.
        * include/parallel/base.h: Likewise; remove unsuitable comment.



I would also like to tackle other XXX todos, if the respective creators
could explain them to me:

include/parallel/checkers.h:  // XXX Compare default template argument
include/parallel/for_each_selectors.h:  // XXX move into type_traits?
include/parallel/partition.h:        // XXX _Compare must have
first__ValueType, second__ValueType,
include/parallel/partition.h:        // XXX binder2nd only for _RAIters??

The other ones are clear to me, but not so easy to fix.


Johannes

-------------- next part --------------
A non-text attachment was scrubbed...
Name: compare_in_last_place.patch
Type: text/x-patch
Size: 1444 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/libstdc++/attachments/20090923/29fabf39/attachment.bin>


More information about the Libstdc++ mailing list