PR v3/38923: symbol versioning disabled on Solaris due to sed.

Jakub Jelinek jakub@redhat.com
Mon Oct 26 12:49:00 GMT 2009


On Fri, Oct 23, 2009 at 08:25:14AM +0200, Ralf Wildenhues wrote:
> * Jason Merrill wrote on Fri, Oct 23, 2009 at 07:07:47AM CEST:
> > On 09/22/2009 09:21 PM, Ralf Wildenhues wrote:
> > >	PR libstdc++/38923
> > >	* acinclude.m4 (GLIBCXX_CHECK_LINKER_FEATURES): Avoid 'head',
> > >	use sed script portable to Solaris /bin/sed for extracting ld
> > >	version.
> > >	* configure: Regenerate.
> > 
> > This patch broke symbol versioning on Fedora 11, and I'm surprised
> > that the pattern would work on any target.
> 
> I managed to try only on targets which have a part in parenthesis added.
> :-/
> 
> > >+         sed -e 's/GNU g*o*ld v*e*r*s*i*o*n* *\(([^)]*)* *\) \([0-9.][0-9.]*\).*/\2/; q'`
> > 
> > The "\(([^)]* *\) " bit requires at minimum "( " which is not
> > present in GNU ld --version on my system.
> 
> My first idea would be to stick in another *, as below, but now I'm not
> so sure this wouldn't allow too much, thus would be able to match
> wrongly.  Maybe it is better to make a bit longer but more reliable
> script.

Definitely.  With all the *'s it can match all kinds of unexpected stuff.

	Jakub



More information about the Libstdc++ mailing list