merge branch profile-stdlib

Silvius Rus rus@google.com
Fri Oct 2 23:10:00 GMT 2009


On Wed, Sep 30, 2009 at 10:42 PM, Benjamin Kosnik <bkoz@redhat.com> wrote:
>
> Silvius.
>
> Please merge this branch into trunk for gcc-4.5. I've made some minor
> fixes so that the testsuite runs without error and the documentation
> is autogenerated correctly, which I've already checked in to the
> profile-stdlib branch. For your reference, I am attaching them to this
> email.
>

I just committed 152423 to the branch, to addresses these final issues.

> I have a couple of requests.
>
> 1) Please add 2009 to the copyright on the source files
>

Done.

> 2) the xml docs need a bibiliography section with a reference to your
> CGO 2009 paper. Great read, highly recommended.
>

Done.  Thank you :).

> 3) doxygen documentation is lacking for the include/profile/vector
> class, and all other classes. Please add some markup so that these
> classes are visible in the doxygen docs. It is easier to see this lack
> now that the files are being scanned...
>

Added at least @brief markup for every new namespace/class.

> There are some formatting issues but that will be easiest to just deal
> with once it's merged.
>
> Thanks for your extreme patience, will try to be better in the future.
> Look forward to seeing more on this, especially string policy work.
>
> best,
> benjamin

I'm very happy that the profile extension is making it to trunk for 4.5.

Thank you for the review, changes and approval.  Many thanks also to
Paolo Carlini and Jonathan Wakely for excellent earlier reviews and
recommendations, and to Diego Novillo for guidance with GCC
source tree mechanics.

I am planning to do a final trunk-to-branch update, then
merge the branch into trunk later today. Will send out an announcement
once it's all done.

Silvius



More information about the Libstdc++ mailing list