std::string overloads for xfstream

Smith-Rowland, Edward M ESmith-rowland@alionscience.com
Wed Mar 25 19:09:00 GMT 2009


Greetings,

Here is another round.  I removed the mains in the testcases.

I'm positive all the extra terminal whitespace has been removed.
I did 'egrep " +$" ' on everything and checked in my editor too there was no terminating whitespece in the last patch.

Now I *did* remove some preexisting terminal whitespace in fstream in addition to the testcases.  So there is some cleanup there that maybe looked like committed whitespace?

Also, I removed the chapter and verse numbers as requested.

Maybe someday we could add not the numbers but the section names.
For example:

?lebuf.members
or
ifstream.cons

That seems more maintainable (which is probably why the standards editors do it).
OTOH, it looks like it is implicit in the directory structure?

Another day perhaps.

-----Original Message-----
From: Paolo Carlini [mailto:paolo.carlini@oracle.com]
Sent: Wed 3/25/2009 12:47 PM
To: Smith-Rowland, Edward M
Cc: libstdc++@gcc.gnu.org
Subject: Re: std::string overloads for xfstream
 
Smith-Rowland, Edward M wrote:
> Here is the corrected patch.
>
> The references to the standard are correct as of the mailing yesterday ;-)
>   
Good, but I would say let's remove the references anyway, the new
standard is not final yet. I would not ask you to do that if I had not
noticed that the trailing blank lines are still there... Also, while you
are at it, being compile-only testcases, you can also remove the mains.

Thanks,
Paolo.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: CL_fstream_string
Type: application/octet-stream
Size: 1256 bytes
Desc: CL_fstream_string
URL: <http://gcc.gnu.org/pipermail/libstdc++/attachments/20090325/61df52b6/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fstream_string.patch
Type: text/x-patch
Size: 25418 bytes
Desc: fstream_string.patch
URL: <http://gcc.gnu.org/pipermail/libstdc++/attachments/20090325/61df52b6/attachment.bin>


More information about the Libstdc++ mailing list