PATCH, v3: fix error from configure

Ben Elliston bje@au1.ibm.com
Fri Jan 2 04:15:00 GMT 2009


On Tue, 2008-12-23 at 07:34 -0800, Ian Lance Taylor wrote:

> The problem would seem to be that GLIBCXX_ENABLE_THREADS comes after
> GLIBCXX_ENABLE_ATOMIC_BUILTINS in libstdc++-v3/configure.ac.  Can you
> try just flipping those two?

That worked.  By making this change (and backing out my earlier patch*
to make the test expression robust against empty strings), the error
went away on the systems I tested on.  For all targets tested, the
generated config.h was unaffected by the order of these macros (ie.
that's how I tested it).

I therefore propose to commit the following patch, but leave my earlier
patch in place--it won't do any harm.  Okay for the trunk?

* http://gcc.gnu.org/viewcvs/trunk/libstdc%2B%2B-v3/acinclude.m4?r1=142714&r2=142829&pathrev=142829&diff_format=h


2009-01-02  Ben Elliston  <bje@au.ibm.com>

        * configure.ac: Exchange the order of GLIBCXX_ENABLE_THREADS and
        GLIBCXX_ENABLE_ATOMIC_BUILTINS macro invocations.
        * configure: Regenerate.

Index: configure.ac
===================================================================
--- configure.ac        (revision 142999)
+++ configure.ac        (working copy)
@@ -97,8 +97,8 @@
 # Enable compiler support that doesn't require linking.
 GLIBCXX_ENABLE_SJLJ_EXCEPTIONS
 GLIBCXX_ENABLE_PCH($is_hosted)
+GLIBCXX_ENABLE_THREADS
 GLIBCXX_ENABLE_ATOMIC_BUILTINS
-GLIBCXX_ENABLE_THREADS
 
 # Checks for compiler support that doesn't require linking.
 GLIBCXX_CHECK_COMPILER_FEATURES




More information about the Libstdc++ mailing list