[C++ PATCH] Optimize C++ comdat ctors/dtors in classes without virtual bases (PR c++/3187, take 3)

Jason Merrill jason@redhat.com
Tue Dec 1 15:05:00 GMT 2009


On 12/01/2009 02:45 AM, Jakub Jelinek wrote:
> On Mon, Nov 30, 2009 at 10:46:31PM -0500, Jason Merrill wrote:
>> On 11/30/2009 05:36 PM, Jakub Jelinek wrote:
>>> 	* config/abi/pre/gnu.ver: Don't export certain base dtors that
>>> 	weren't previously exported.
>>
>> Is this necessary?
>
> Yes.

OK.

>>> +	&&  (SUPPORTS_ONE_ONLY || !DECL_WEAK (fns[0]))
>>
>> This test seems unnecessary; I don't see the problem with using aliases
>> on targets with weak symbols but no one-only support.
>
> This is to fix AIX (and is actually unrelated to this patch, it can be dealt
> with separately).  In theory it should work well, but David Edelsohn
> reported that some symbols were missing from libstdc++.so without it.  I
> have no access to AIX and have no idea what AIX linker is doing with the
> symbols.

OK.

The patch is OK.

Jason



More information about the Libstdc++ mailing list