[PATCH, v3] Drop trailing white space in include/Makefile.am
Ralf Wildenhues
Ralf.Wildenhues@gmx.de
Tue Jun 24 19:19:00 GMT 2008
* Benjamin Kosnik wrote on Tue, Jun 24, 2008 at 09:03:12PM CEST:
> > - The white space in 'ext_builddir = ./ext ' can cause subtle bugs in
> > the generated Makefile.in (with newer automake, I was looking at a
> > seemingly nonsensical build failure for a while).
>
> I'll say this is subtle.... wow. In what version of automake does this
> start to be a factor?
Hmm. Thinking about it, it doesn't get exposed unless another patch in
my queue is applied. So I'm sorry I gave the wrong motivation here.
I have a patch that removes the install-headers* targets completely,
replacing them with automake macros like this:
gxx_include_extdir = ${gxx_include_dir}/${ext_builddir}
nodist_gxx_include_ext_HEADERS = ${ext_headers}
This means automake's install rules are used. It's this patch that
exposes the trailing whitespace, by trying to access
$(gxx_include_extdir)/filename.h.
I haven't posted the patch yet, because, with Automake 1.9.6, it works
but is a lot slower than the install rules the file has currently. With
current git Automake, however, it takes half the time. So I was going
to propose this patch after a move to more recent autotools.
Cheers,
Ralf
More information about the Libstdc++
mailing list