Troubles with the rvalref changes to the *_heap functions

Paolo Carlini pcarlini@suse.de
Tue Oct 9 09:19:00 GMT 2007


Hi,

>>  for(int i = 1; i < 9; ++i)
>>  {
>>    for(int z = 0; z < i; ++z)
>>      array[i] = i;
>>    
>>
>Yes, that certainly should be array[z] = z; The rest of that function
>looks correct, although I haven't tested it yet.
>  
>
Ok, thanks. To be clear, after that change, the testcase keeps failing 
for me, badly.

>While I'm very happy to be seeing rvalue references entering the
>library and compiler, Unfortunately, at the moment I only have access
>to a windows machine, where I have been unable to get a modern copy of
>gcc to compile for quite some time.
>
>The heap functions are indeed messy, I remember a number of them had
>to take rvalue parameters, which look unpleasant. Fortunatly most of
>the nastiness of these should simply be removable. I hope to have a
>new computer in a couple of weeks, at which point if you haven't
>finished the code I would be happy to have a look.
>  
>
Agreed. Please keep in touch and let's have all this stuff in mainline 
for 4.3. In the meanwhile maybe I will work on other bits of it ...

Paolo.



More information about the Libstdc++ mailing list