ABI check is (potentially) missing some symbol size changes.

Paolo Carlini pcarlini@suse.de
Wed Jul 25 19:50:00 GMT 2007


Stephen Webb wrote:

>We noticed that a small coding error in the ABI check utility is causing some 
>symbol size changes to go undetected.  Although nothing is currently being 
>missed in the mainline codebase, it's possible that something might slip by 
>in the future.
>  
>
Gosh, very good catch, thanks! Luckily, I gather, why didn't do any 
mistake, in the meanwhile...

>OK to commit to trunk?
>  
>
Yes. In fact, I think the patch is very useful in 4_2-branch too, let's 
just wait a couple of days.

>2007-07-25  Stephen M. Webb <stephenw@xandros.com>
>
>	Fixed abi_check for missing symbol size changes.
>	* testsuite/util/testsuite_abi.cc: changed local variable name to
>	  prevent member variable hiding.
>  
>
Minor nits you will probably notice anyway, when adding the ChangeLog 
entry: double space between name and email; capitalize Changed; indent 
prevent to *; probably no text on top,  that is before *.

Thanks,
Paolo.



More information about the Libstdc++ mailing list