[PATCH] libstdc++/8761 and libstdc++/7076

[Benjamin Kosnik]

Sorry I'm so behind on patch review at the moment. Regardless of
long-term issues of format cache versus locale info cache, this is some
feedback on your patch as is.

There was an attempt to cache facet values directly in the io heirarchy
in the past. See _M_fcvt, etc. These, and the _Format_cache bits were
taken out at the same time due to corectness issues.

Now that locales are on more solid ground, it's time to look at figuring
out how to do a general cache strategy. 

On Fri, 10 Jan 2003 01:50:20 -0500
Jerry Quinn <jlquinn@optonline.net> wrote:

>I believe I've put the specializations in the right place, but please verify.

You did, there were some very minor bits. There is some confusion in the
curent code about declaration of other specializations vs. definitions
of generics (ie more of libstdc++/9269) so I can see why you'd be a bit
uncertain. I fixed this up in this version of your combined patches,
plus moved some things around a bit, so maybe it's easier to see where
to put the specialization declarations, and generic definitions.

This compiles, I do get an extra link fail in
22_locale/num_put_members_char.cc, but it's probably something .... I
will look at it in a bit (seems wierd, it's defined in src/locale.cc)
and 27_io/ios_manip_basefield.cc also has an execution fail. Also
27_io/ostream_inserter_arith. These may both be export-list related, or
not. Hmm.

Did you run 'make check' and 'make check-abi?'. Hmm.

The c_locale.h duplication between gnu and generic is unfortunate but
necessary for the moment. 

How do I go about verifying the performance issues again?

best,
benjamin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: p.20030111-2
Type: application/octet-stream
Size: 34061 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/libstdc++/attachments/20030111/aa04791a/attachment.obj>