PATCH: back at you

Phil Edwards phil@jaj.com
Fri Apr 25 23:25:00 GMT 2003


On Fri, Apr 25, 2003 at 04:35:44PM -0500, Loren James Rittle wrote:
> I also fixed the
> nit I found: i486 was missing from its namesake file!
[...]
> 	* configure.target (athlon, i586+): Add i486 to list to use cpu/i486.
> 	(i386): New case.

None of these three need to be listed.  :-)  The 'DEFAULTS' clause, just
above where you edited, takes care of i486.  i386 doesn't need an entry
either, for the same reason:  <cpu> will default to config/cpu/<cpu>.

Also, athlon* doesn't need an entry.  (I thought it did at one point,
but I was wrong.)  The target_cpu variable is the "canonicalized form"
from config.sub, so athlon* will have been replaced by, e.g., i686 at
this point.  Likewise for k6 and other "aliases".

(Now, pushes have been made in the compiler area to remember the differences.
If we ever need to distinguish, say, Athlon from Intel, then we'll have to
look at target_alias and assign them to different files.  I always specify
athlon_mp myself, because that's what I have, and the compiler takes note.
Our own configury mostly sees "i686".)


> 	* config/cpu/i386/atomicity.h: New file.

I'm not qualified to review that part, but a brief look didn't show anything
obviously wrong.


Phil

-- 
If ye love wealth greater than liberty, the tranquility of servitude greater
than the animating contest for freedom, go home and leave us in peace.  We seek
not your counsel, nor your arms.  Crouch down and lick the hand that feeds you;
and may posterity forget that ye were our countrymen.            - Samuel Adams



More information about the Libstdc++ mailing list