Patch: Re: Blanket replacement of "xgcc" in libstdc++-v3/testsuite/Makefile.am

[Phil Edwards]

On Fri, Apr 25, 2003 at 10:35:37AM -0500, Benjamin Kosnik wrote:
> 
> I think this is fine, but maybe
> 
> >CXX_fake = @glibcpp_CXX@
> >-CXX=`echo $(CXX_fake) | sed 's/xgcc/g++/g'`
> >+CXX=`echo "$(CXX_fake) " | sed 's/xgcc /g++/'`
> 
> should be
> 
> +CXX=`echo "$(CXX_fake) " | sed 's/gcc\/xgcc /gcc\/g++ /'`

When working with paths, it's usually more readable to choose a different
separator character instead of escaping the slash, e.g.,

   CXX=`echo "$(CXX_fake) " | sed 's,gcc/xgcc ,gcc/g++ ,'`

Exclamation points and equal signs are also good candidates.


Phil

-- 
If ye love wealth greater than liberty, the tranquility of servitude greater
than the animating contest for freedom, go home and leave us in peace.  We seek
not your counsel, nor your arms.  Crouch down and lick the hand that feeds you;
and may posterity forget that ye were our countrymen.            - Samuel Adams