[PATCH] remove target dependency for atomicity.h on ix86
Phil Edwards
phil@jaj.com
Wed Apr 23 20:42:00 GMT 2003
On Wed, Apr 23, 2003 at 10:13:14PM +0200, Matthias Klose wrote:
> --- libstdc++-v3/config/cpu/generic/atomicity.h~ 2003-02-22 06:08:04.000000000 +0100
> +++ libstdc++-v3/config/cpu/generic/atomicity.h 2003-04-23 09:24:46.000000000 +0200
> @@ -32,10 +32,37 @@
>
> #include <bits/gthr.h>
>
> +// need to define this in any case
> #define _GLIBCPP_NEED_GENERIC_MUTEX
>
> typedef int _Atomic_word;
>
> +#if defined(__i486) || defined(__i586) || defined(__i686) || defined(__k6) || defined(__athlon) || defined(__pentium4) || defined(__x86_64)
> +// the "i486" and above part
[...]
> +#else
> +// the "generic" (i386) part
Eeeuuuuccch. I'm not at all keen on dumping x86-specific stuff into
the generic header. It's used on platforms other than just i386. If we
make "generic" magically aware of i486s, we're doing an end-run around
the confirguration machinery. Might as well put /all/ of the supported
platforms in this one file and use #if to distinguish them.
Phil
--
If ye love wealth greater than liberty, the tranquility of servitude greater
than the animating contest for freedom, go home and leave us in peace. We seek
not your counsel, nor your arms. Crouch down and lick the hand that feeds you;
and may posterity forget that ye were our countrymen. - Samuel Adams
More information about the Libstdc++
mailing list