[Patch] More redundant NULL pointer checks

Nathan Myers ncm-nospam@cantrip.org
Mon Apr 21 17:44:00 GMT 2003


On Mon, Apr 21, 2003 at 12:21:32PM -0500, Benjamin Kosnik wrote:
> 
> Ok, except the sgetc change, don't do this. Also, your line breaks are funny:
> 
> +      const bool __testeof =
> +        traits_type::eq_int_type(__c, traits_type::eof());
> 
> Should be:
> 
> +      const bool __testeof = traits_type::eq_int_type(__c, 
> +                                                      traits_type::eof());

I disagree.  Indenting to the "(" eliminates most of the value
of the line break in the first place.  I thought I had written this 
choice into the formatting standard.  Emacs is easily fixed to do
the right thing.

Nathan Myers
ncm-nospam@cantrip.org



More information about the Libstdc++ mailing list