top-level configure: preserve quotes in arguments (Was: Re: [libstdc++] libstdc++/7691, pass -Wabi, sanity checks)

Phil Edwards phil@jaj.com
Wed Oct 16 18:49:00 GMT 2002


Coming back to this after too long...

On Wed, Sep 04, 2002 at 03:27:44PM -0500, Benjamin Kosnik wrote:
> 
> > Hmm...  There's one thing I dislike about your patch, which is that it
> > turns --enable-cxx-flags= into --enable-cxx-flags (with an implicit
> > =yes).  I'd rather set addoption to the entire string to be added to
> > $arguments, quoted if necessary.
> 
> I agree. Thoughts? Phil, what do you think? Does this look ok?

>From what I can tell it looks okay.  Certainly GLIBCPP_ENABLE_CXX_FLAGS
could be modified to accept and ignore a default =yes, but Alexandre's
points should probably be addressed.  The PR remains open, after all.  :-)


Phil

-- 
I would therefore like to posit that computing's central challenge, viz. "How
not to make a mess of it," has /not/ been met.
                                                 - Edsger Dijkstra, 1930-2002



More information about the Libstdc++ mailing list