[PATCH] libstdc++/6648

Paolo Carlini pcarlini@unitus.it
Tue May 14 03:31:00 GMT 2002


Loren James Rittle wrote:

>>the below fixes this PR, which Peter (Schmid) filed a few hours ago. [...]
>>    
>>
>Paolo,
>
>WOW! ;-)  I agree that this is an unfortunate failure to ship with.
>
>I believe that a non-interactive test case is producible.  This
>non-interactive test fails without your patch:
>
>#include <fstream>
>
>int main ()
>{
>  const char str_lit01[] = "YYY.txt";
>  std::ifstream if01 (str_lit01, std::ios_base::in);
>  char buff[2048];
>  int i;
>
>  if01.getline(buff, 2048);
>  if01.ignore(2048, '\n');
>  if01 >> i;
>  if (i != 123) exit (1);
>}
>
>In YYY.txt:
>
>test\n
>123\n
>EOF
>
>Can you confirm that it works with your patch? If this non-interactive
>version works as well to spot the regression point, please install it
>in place or in addition of your interactive version (please adapt it
>as required - hints below).
>
Hi Loren.

I completely agree with you that we must strieve for non-interactive 
tests, which everyone runs by default. However, the particular version 
you provided does not work very well for me with both 3.1, 3.1 + my 
patch and Icc.

Can you possibly work on refining it?

In the meanwhile, if Benjamin agrees with the fix itself, I will commit 
it together with the interactive :-( tests...

Ciao,
Paolo.



More information about the Libstdc++ mailing list