Patch for 64-bit HP-UX libstdc++-v3
Douglas Gregor
gregod@cs.rpi.edu
Wed Mar 13 19:19:00 GMT 2002
> >
> > Thanks for the patch. I think the idea for a general solution, outlined
> > in the link below, is a better way to solve this for everybody:
> >
> > http://gcc.gnu.org/ml/libstdc++/2002-02/msg00169.html
> >
> > I'd appreciate it if you could test this patch, and let the list know
> > your results. If it works, then all the HPUX-specific hackery can get
> > removed. Sound good?
> Yes, that sounds like a better solution.
>
> One thing that needs to happen tough -- the code for libiberty needs to be
> updated to conform to the GNU coding standards -- a run through gnu-indent
> and a one-over by a human ought to take care of the conversion from KNF to
> GNU form.
The libiberty bits were copied directly from libiberty's strtol.c and
strtoul.c, with only a glorified s/long/long long to get the types right.
I've regenerated the patch against the trunk and brought the libiberty bits
up to GNU coding standards AFAICT.
Doug Gregor
-------------- next part --------------
A non-text attachment was scrubbed...
Name: strtoull.c
Type: text/x-c
Size: 3523 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/libstdc++/attachments/20020313/bd4dc2b4/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libstdc++-v3-gcc-head-strtoll.patch
Type: text/x-diff
Size: 6503 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/libstdc++/attachments/20020313/bd4dc2b4/attachment-0001.bin>
-------------- next part --------------
/*-
* Copyright (c) 1990 The Regents of the University of California.
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
* 3. [rescinded 22 July 1999]
* 4. Neither the name of the University nor the names of its contributors
* may be used to endorse or promote products derived from this software
* without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*/
#ifdef HAVE_CONFIG_H
#include "config.h"
#endif
#ifdef HAVE_LIMITS_H
#include <limits.h>
#endif
#ifdef HAVE_SYS_PARAM_H
#include <sys/param.h>
#endif
#include <errno.h>
#ifdef NEED_DECLARATION_ERRNO
extern int errno;
#endif
#include "safe-ctype.h"
/* FIXME: It'd be nice to configure around these, but the include files are too
painful. These macros should at least be more portable than hardwired hex
constants. */
#ifndef ULONG_LONG_MAX
#define ULONG_LONG_MAX ((unsigned long long)(~0LL))
#endif
#ifndef LONG_LONG_MAX
#define LONG_LONG_MAX ((long long)(ULONG_LONG_MAX >> 1))
#endif
#ifndef LONG_LONG_MIN
#define LONG_LONG_MIN ((long long)(~LONG_LONG_MAX))
#endif
/*
* Convert a string to a long long integer.
*
* Ignores `locale' stuff. Assumes that the upper and lower case
* alphabets and digits are each contiguous.
*/
long long
strtoll (nptr, endptr, base)
const char *nptr;
char **endptr;
register int base;
{
register const char *s = nptr;
register unsigned long long acc;
register int c;
register unsigned long long cutoff;
register int neg = 0, any, cutlim;
/*
* Skip white space and pick up leading +/- sign if any.
* If base is 0, allow 0x for hex and 0 for octal, else
* assume decimal; if base is already 16, allow 0x.
*/
do
{
c = *s++;
}
while (ISSPACE (c));
if (c == '-')
{
neg = 1;
c = *s++;
}
else if (c == '+')
c = *s++;
if ((base == 0 || base == 16) && c == '0' && (*s == 'x' || *s == 'X'))
{
c = s[1];
s += 2;
base = 16;
}
if (base == 0)
base = c == '0' ? 8 : 10;
/*
* Compute the cutoff value between legal numbers and illegal
* numbers. That is the largest legal value, divided by the
* base. An input number that is greater than this value, if
* followed by a legal input character, is too big. One that
* is equal to this value may be valid or not; the limit
* between valid and invalid numbers is then based on the last
* digit. For instance, if the range for long longs is
* [-2147483648..2147483647] and the input base is 10,
* cutoff will be set to 214748364 and cutlim to either
* 7 (neg==0) or 8 (neg==1), meaning that if we have accumulated
* a value > 214748364, or equal but the next digit is > 7 (or 8),
* the number is too big, and we will return a range error.
*
* Set any if any `digits' consumed; make it negative to indicate
* overflow.
*/
cutoff = neg ? -(unsigned long long) LONG_LONG_MIN : LONG_LONG_MAX;
cutlim = cutoff % (unsigned long long) base;
cutoff /= (unsigned long long) base;
for (acc = 0, any = 0;; c = *s++)
{
if (ISDIGIT (c))
c -= '0';
else if (ISALPHA (c))
c -= ISUPPER (c) ? 'A' - 10 : 'a' - 10;
else
break;
if (c >= base)
break;
if (any < 0 || acc > cutoff || acc == cutoff && c > cutlim)
any = -1;
else
{
any = 1;
acc *= base;
acc += c;
}
}
if (any < 0)
{
acc = neg ? LONG_LONG_MIN : LONG_LONG_MAX;
errno = ERANGE;
}
else if (neg)
acc = -acc;
if (endptr != 0)
*endptr = (char *) (any ? s - 1 : nptr);
return (acc);
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libiberty-gcc-head-strtoll.patch
Type: text/x-diff
Size: 4890 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/libstdc++/attachments/20020313/bd4dc2b4/attachment-0002.bin>
More information about the Libstdc++
mailing list