Grab bag of stuff

Loren James Rittle rittle@latour.rsch.comm.mot.com
Fri Jun 7 00:56:00 GMT 2002


FYI, someone recently broke 'make check-script' in libstdc++-v3.  I
think it happened when the testsuite_hooks implementation went to a
library from a header.  If it was you, then please consider fixing it
(or let us officially remove it; and I vote to fix it).

Speaking of that change...

This patch (or a more aggressive version that moves the null
implementation into the library) must be applied for hosts that don't
define _GLIBCPP_MEM_LIMITS (I will do it as obvious with appropriate
ChangeLog entry after it bootstraps/checks in my tree for a night,
unless someone speaks up for the aggressive change):

Index: testsuite/testsuite_hooks.h
===================================================================
RCS file: /cvs/gcc/gcc/libstdc++-v3/testsuite/testsuite_hooks.h,v
retrieving revision 1.7
diff -c -r1.7 testsuite_hooks.h
*** testsuite/testsuite_hooks.h	28 May 2002 23:15:12 -0000	1.7
--- testsuite/testsuite_hooks.h	7 Jun 2002 07:18:19 -0000
***************
*** 66,72 ****
  // Defined in GLIBCPP_CONFIGURE_TESTSUITE.
  #ifndef _GLIBCPP_MEM_LIMITS
  // Don't do memory limits.
! extern void
  __set_testsuite_memlimit(float x = 0)
  { }
  
--- 66,72 ----
  // Defined in GLIBCPP_CONFIGURE_TESTSUITE.
  #ifndef _GLIBCPP_MEM_LIMITS
  // Don't do memory limits.
! inline void
  __set_testsuite_memlimit(float x = 0)
  { }
  
Speaking of that, I wondered why my BSD box wasn't using said
_GLIBCPP_MEM_LIMITS path.  Reason, none of the configure checks
include both <sys/types.h> (or <unistd.h>) and <sys/time.h> before
<sys/resource.h>.  Thus, some basic types were incomplete at the time
they were seen in prototypes in <sys/resource.h>.  I wonder how many
ports are negatively affected by this.  I will produce a patch that
reorders them in testsuite/testsuite_hooks.cc and the related
configure tests.

BTW, according to the older POSIX standard (granted, changed for
modern POSIX), a system can be cranky on this point.  To use parts of
<sys/resource.h>, you have to explicitly include <sys/time.h>.

Regards,
Loren



More information about the Libstdc++ mailing list