[PATCH] fix libstdc++/5611

Benjamin Kosnik bkoz@redhat.com
Mon Feb 18 12:55:00 GMT 2002


This is a pretty interesting patch. It's not acceptable in it's current
form for mainline, but could be modified pretty easily. Loren and others
have been thinking about this for awhile: I'm expecting more comments. 

Here are my comments on how to get this into current CVS:

1) Index: include/bits/locale_facets.tcc

Move this to 
/config/locale/c_locale_generic.cc

2) Index: src/Makefile.am

Don't unconditionally link in libiberty. This should be done 
conditionally, see how libio and libmath work.

Other than that, nice job! I realize you're patching against gcc-3.0.x, 
so my comments aren't really applicable for that source base. I leave 
that decision to somebody else, but I think this kind of change is not 
advisable for the gcc-3.0 branch. I'd like to see it in mainline though, 
when the above is worked out.

-benjamin



More information about the Libstdc++ mailing list