__num_base::_S_scale_{hex,oct}

Jakub Jelinek jakub@redhat.com
Thu Apr 4 13:35:00 GMT 2002


On Thu, Apr 04, 2002 at 01:26:13PM -0800, Benjamin Kosnik wrote:
> 
> > What's the point in computing __num_base::_S_scale_{hex,oct} costly in
> > constructor when it is never used (the only user
> > in include/bits/locale_facets.tcc was removed ~ 2 month ago)?
> 
> Remove it then....

Here is a patch. Ok to commit? Trunk only or branch too?

2002-04-04  Jakub Jelinek  <jakub@redhat.com>

	* include/bits/locale_facets.h (__num_base::_S_scale_hex): Remove.
	(__num_base::_S_scale_oct): Remove.
	* src/locale.cc (__num_base::_S_scale_hex): Remove.
	(__num_base::_S_scale_oct): Remove.

--- libstdc++-v3/src/locale.cc.jj	Wed Mar 13 02:04:12 2002
+++ libstdc++-v3/src/locale.cc	Thu Apr  4 23:38:12 2002
@@ -517,10 +517,6 @@ namespace std 
 
   const char __num_base::_S_atoms[] = "0123456789eEabcdfABCDF";
 
-  const double __num_base::_S_scale_hex = log(10.0)/log(16.0);
-
-  const double __num_base::_S_scale_oct = log(10.0)/log(8.0);
-
   bool
   __num_base::_S_format_float(const ios_base& __io, char* __fptr, char __mod,
 			      streamsize __prec)
--- libstdc++-v3/include/bits/locale_facets.h.jj	Tue Feb 12 16:19:53 2002
+++ libstdc++-v3/include/bits/locale_facets.h	Thu Apr  4 23:37:40 2002
@@ -421,12 +421,6 @@ namespace std
   class __num_base 
   {
   protected:
-    // Used to establish gating factor for base 16 input.
-    static const double _S_scale_hex;
-    
-    // Used to establish gating factor for base 8 input.
-    static const double _S_scale_oct;
-
     // String literal of acceptable (narrow) input, for num_get.
     // "0123456789eEabcdfABCDF"
     static const char _S_atoms[];


	Jakub



More information about the Libstdc++ mailing list