[PATCH] For SGI stl_algo.h extensions (was: Re: [RFC] Moving apart SGI extensions)

Gabriel Dos Reis gdr@codesourcery.com
Fri Dec 28 05:07:00 GMT 2001


Paolo Carlini <pcarlini@unitus.it> writes:

| Gabriel Dos Reis wrote:
| 
| > Paolo Carlini <pcarlini@unitus.it> writes:
| >
| > | Gabriel Dos Reis wrote:
| > |
| > | > Why not just call it algorithm.h, or algorithm?  After all, it is in
| > | > the separate directory.
| > |
| > | Right: algorithm is ok. #include <ext/algorithm> is nice! I'm correcting this.
| > | For the include guard I propose _EXT_ALGORITHM, however. What do you think?
| >
| > I don't think that is necessary: By the point the user says
| > #include <ext/algorithm>, he is already asking for nonstandard
| > features and I don't think we should go another macro step further in
| > order to have the requested functionnalities in.
| 
| Humm. I get your point, but, on the other hand, *all* the other extensions inside
| include/ext (which I'm about to work on, moving everything to __gnu_cxx) have include
| guards protecting them.
| I don't know sufficiently well the preprocessor to weigh the advantages and disadvantages
| of this.
| What do you suggest?

Don't guard them unless they are things like use of long long or such.

-- Gaby



More information about the Libstdc++ mailing list