[PATCH] _M_replace (take3): better clean up + speed ups!!

[Phil Edwards]

On Sun, Dec 09, 2001 at 01:00:58PM +0100, Paolo Carlini wrote:
> And there are *good* numbers!

Those are /very/ good numbers.  This is quite impressive.

I'll leave commenting on this patch to others (I am not as familiar with
string), but I'll mention this purely as a matter of form:

>         * include/bits/basic_string.tcc (_M_replace_safe): New.
>         * include/bits/basic_string.tcc (_M_replace(input_iterator_tag),
>         append members): use it.
>         * include/bits/basic_string.tcc (_M_replace(forward_iterator_tag)): Remove.
>         * include/bits/basic_string.h: Adjust declarations.
>         * src/string-inst.cc: Adjust declarations.

Files are usually listed multiple times only when there are unreleated
changes; for this patch, a better entry would be:

    * include/bits/basic_string.tcc (_M_replace_safe):  New function.
    (_M_replace(input_iterator_tag), append members):  Use it.
    (_M_replace(forward_iterator_tag)):  Remove.
    * include/bits/basic_string.h:  Adjust declarations.
    * src/string-inst.cc:  Adjust declarations.


Nice work!
Phil

-- 
If ye love wealth greater than liberty, the tranquility of servitude greater
than the animating contest for freedom, go home and leave us in peace.  We seek
not your counsel, nor your arms.  Crouch down and lick the hand that feeds you;
and may posterity forget that ye were our countrymen.            - Samuel Adams