PATCH: 'long long' support

Gabriel Dos Reis Gabriel.Dos-Reis@cmla.ens-cachan.fr
Sat Apr 1 00:00:00 GMT 2000


Chip Salzenberg <chip@valinux.com> writes:

| With these patches, I built a libstdc++ with 'long long' support.
| I hope they'll be acceptable.  The one part I'm not sure about is the
| change to _S_format_long (now _S_format_integer), which ends up using
| 'long long' math for all integral output.  I'll have to bench it.

Thanks for your patch.  

Here are some comments: I think you actually did more than just adding
support for long long.  It would be appreciable, if you can add
appropriate ChangeLog entries etlling what you did. It helps keep trap
of changes.  Also please, avoid unnecessary reformating.  


[...]

| @@ -1056,14 +1057,20 @@
|        { return do_put(__s, __f, __fill, __v); }
|  
| +      iter_type 
| +      put(iter_type __s, ios_base& __f, char_type __fill, 
| +	  unsigned long __v) const
| +      { return do_put(__s, __f, __fill, __v); }
| +

You made an addition here.  Please record it.

[...]

|        iter_type 
| @@ -1093,11 +1100,16 @@
|        do_put(iter_type, ios_base&, char_type __fill, long __v) const;
|  
| +      virtual iter_type 
| +      do_put(iter_type, ios_base&, char_type __fill, unsigned long) const;
| +

Ditto.

|  #ifdef _GLIBCPP_USE_LONG_LONG 
|        virtual iter_type 
| -      do_put(iter_type, ios_base&, char_type __fill, long long __v) const;
| -#endif
| +      do_put(iter_type, ios_base&, char_type __fill,
| +	     long long __v) const;

Unnecessary reformat.

[...]

Could you resumbit a revised patch, please?
Thanks.

-- Gaby


More information about the Libstdc++ mailing list