[gcc r16-4158] libstdc++: Add missing parentheses to tests with wrong precedence
Jonathan Wakely
redi@gcc.gnu.org
Wed Oct 1 12:57:29 GMT 2025
https://gcc.gnu.org/g:b304532350f54e4d14ed64f2ce5dc9139135521b
commit r16-4158-gb304532350f54e4d14ed64f2ce5dc9139135521b
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Tue Sep 30 17:10:42 2025 +0100
libstdc++: Add missing parentheses to tests with wrong precedence
These tests are currently evaluated as (err == failbit)|eofbit which is
not what we want. It should be err == (failbit|eofbit).
libstdc++-v3/ChangeLog:
* testsuite/22_locale/time_get/get/char/3.cc: Add parentheses to
x == y|z expression.
* testsuite/22_locale/time_get/get/wchar_t/3.cc: Likewise.
* testsuite/28_regex/algorithms/regex_match/multiline.cc:
Likewise.
Reviewed-by: Tomasz Kamiński <tkaminsk@redhat.com>
Diff:
---
libstdc++-v3/testsuite/22_locale/time_get/get/char/3.cc | 2 +-
libstdc++-v3/testsuite/22_locale/time_get/get/wchar_t/3.cc | 2 +-
libstdc++-v3/testsuite/28_regex/algorithms/regex_match/multiline.cc | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/libstdc++-v3/testsuite/22_locale/time_get/get/char/3.cc b/libstdc++-v3/testsuite/22_locale/time_get/get/char/3.cc
index 48a5f12e26e8..49bcd2adbcb1 100644
--- a/libstdc++-v3/testsuite/22_locale/time_get/get/char/3.cc
+++ b/libstdc++-v3/testsuite/22_locale/time_get/get/char/3.cc
@@ -226,7 +226,7 @@ test01()
format = "%e";
ret = tget.get(iter(iss), end, iss, err, &time,
format.data(), format.data()+format.size());
- VERIFY( err == ios_base::failbit|ios_base::eofbit );
+ VERIFY( err == (ios_base::failbit|ios_base::eofbit) );
VERIFY( ret == end );
iss.str("35");
diff --git a/libstdc++-v3/testsuite/22_locale/time_get/get/wchar_t/3.cc b/libstdc++-v3/testsuite/22_locale/time_get/get/wchar_t/3.cc
index b7eb5bcb204a..4b1b6e4924e6 100644
--- a/libstdc++-v3/testsuite/22_locale/time_get/get/wchar_t/3.cc
+++ b/libstdc++-v3/testsuite/22_locale/time_get/get/wchar_t/3.cc
@@ -226,7 +226,7 @@ test01()
format = L"%e";
ret = tget.get(iter(iss), end, iss, err, &time,
format.data(), format.data()+format.size());
- VERIFY( err == ios_base::failbit|ios_base::eofbit );
+ VERIFY( err == (ios_base::failbit|ios_base::eofbit) );
VERIFY( ret == end );
iss.str(L"35");
diff --git a/libstdc++-v3/testsuite/28_regex/algorithms/regex_match/multiline.cc b/libstdc++-v3/testsuite/28_regex/algorithms/regex_match/multiline.cc
index a1982fc8f786..f4b3cf03a225 100644
--- a/libstdc++-v3/testsuite/28_regex/algorithms/regex_match/multiline.cc
+++ b/libstdc++-v3/testsuite/28_regex/algorithms/regex_match/multiline.cc
@@ -27,11 +27,11 @@ test01()
VERIFY(std::regex_search("x\nab\nx", ml));
ml.assign("a$\n^b$\n^c", ECMAScript|__multiline);
- VERIFY( ml.flags() == ECMAScript|__multiline );
+ VERIFY( ml.flags() == (ECMAScript|__multiline) );
VERIFY( regex_search("a\nb\nc", ml) );
ml.assign("a$\n^b$\n^c", ECMAScript|__multiline|icase);
- VERIFY( ml.flags() == ECMAScript|__multiline|icase );
+ VERIFY( ml.flags() == (ECMAScript|__multiline|icase) );
VERIFY( regex_search("A\nB\nC", ml) );
}
More information about the Libstdc++-cvs
mailing list